Skip to content

convert to wafv2 resources and add relevant AWS managed rules#86

Open
stonith wants to merge 1 commit into
masterfrom
wafv2
Open

convert to wafv2 resources and add relevant AWS managed rules#86
stonith wants to merge 1 commit into
masterfrom
wafv2

Conversation

@stonith

@stonith stonith commented Jun 30, 2020

Copy link
Copy Markdown
Contributor
  • convert legacy waf rules to wafv2 with latest AWS provider
  • add AWSManagedRulesAmazonIpReputationList, AWSManagedRulesCommonRuleSet, AWSManagedRulesKnownBadInputsRuleSet, AWSManagedRulesLinuxRuleSet, and AWSManagedRulesSQLiRuleSet AWS managed rulesets
  • enabled cloudwatch metrics per rule
  • enable sampling for each rule except for the explicit ALLOW rule
  • enabled rate limiting for /claim-key, /new-key-claim*, and /upload

Upstream of cds-snc/covid-alert-server#118

@stonith stonith requested a review from Ginja June 30, 2020 19:42

@honkfestival honkfestival left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I only took a brief look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants